Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radicale ignore vcard getcontenttype if Address Book collection #100

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Radicale ignore vcard getcontenttype if Address Book collection #100

merged 1 commit into from
Aug 19, 2024

Conversation

matidau
Copy link
Collaborator

@matidau matidau commented Aug 18, 2024

Released under the GNU Affero General Public License (AGPL), version 3

What does this implement/fix? Explain your changes.

As per #67 and Kozea/Radicale#386 (comment) this is to ignore vcard content-type for addressbooks so that Radicale can work.

Does this close any currently open issues?

#67

@matidau
Copy link
Collaborator Author

matidau commented Aug 18, 2024

@rpc-scandinavia would be good if you could test this.

@matidau matidau linked an issue Aug 18, 2024 that may be closed by this pull request
Z-Push do not work with Radicale CardDAV #67
Closed
@matidau matidau merged commit 6575263 into Z-Hub:develop Aug 19, 2024
2 checks passed
@matidau matidau deleted the radicale-addressbook-vcard-content-type branch August 19, 2024 10:20
@rpc-scandinavia
Copy link
Contributor

@rpc-scandinavia would be good if you could test this.

I replaced my Z-Push installation with the current "Develop" branch, and it look like everything is working.

However, I did see something in the error log after upgrading, that I can't recall seeing before. I don't know whether this is related, but here it is:

19/08/2024 23:24:04 [3956718] [ERROR] [x@x.dk] WBXMLDecoder->getElementEndTag(): could not read end tag in '/usr/local/lib/z-push/lib/request/sync.php:539'. Please enable the LOGLEVEL_WBXML and send the log to the Z-Push dev team.
19/08/2024 23:24:04 [3956718] [WARN] [x@x.dk] /usr/local/lib/z-push/lib/wbxml/wbxmldecoder.php:121 Trying to access array offset on value of type null (2)
19/08/2024 23:24:04 [3956718] [FATAL] [x@x.dk] WBXMLException: Unknown error in Sync->Handle() - code: 0 - file: /usr/local/lib/z-push/lib/request/requestprocessor.php:117
19/08/2024 23:24:04 [3956718] [FATAL] [x@x.dk] WBXML 10K debug data: AwFqAE................ removed ................QEB
19/08/2024 23:24:04 [3956718] [FATAL] [x@x.dk] Exception: (WBXMLException) - Unknown error in Sync->Handle()
19/08/2024 23:24:04 [3956718] [FATAL] [x@x.dk] Request could not be processed correctly due to a WBXMLException. Please report this including the 'WBXML debug data' logged. Be aware that the debug data could contain confidential information.

Should I try to "Please enable the LOGLEVEL_WBXML and send the log to the Z-Push dev team" ?
It was another user, so I don't know if it will happen again.

@matidau
Copy link
Collaborator Author

matidau commented Aug 20, 2024

Thank you 😊

This looks like it is related to this issue #99

Do you mind running with LOGLEVEL_WBXML and pasting the output on that issue or a new one?

@rpc-scandinavia
Copy link
Contributor

Do you mind running with LOGLEVEL_WBXML and pasting the output on that issue or a new one?

Yes, I will post on #99 if it appears again with the "LOGLEVEL_WBXML" details.
Btw, In my case, the device is an Android device.

@rpc-scandinavia rpc-scandinavia mentioned this pull request Aug 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Z-Push do not work with Radicale CardDAV
2 participants
@matidau @rpc-scandinavia